Defer playlist reload while network is offline #7926
Open
robwalch wants to merge 1 commit into
Open
Conversation
github-project-automation
Bot
moved this to Top priorities
in HLS.js Release Planning and Backlog
5 tasks
| if (offlineStatus) { | ||
| this.log(`Waiting for connection (offline)`); | ||
| errorEvent.reason = 'offline'; | ||
| this.timer = self.setTimeout(() => this.checkOfflineStatus(), 1000); |
Collaborator
There was a problem hiding this comment.
why timer?
we can probably track navigator.onLine via event Listener:
window.addEventListener("online", loadPlaylist)
Collaborator
Author
There was a problem hiding this comment.
There are some browsers that do not implement that event. The fragment implementation uses polling for that very reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will...
Defer offline media playlist load error retry until online status is restored.
Why is this Pull Request needed?
This makes Live and VOD offline behavior more consistent, since fragment loading retries are already deferred in the same way. Live was more likely to produce a fatal playlist load error than VOD because playlist retries were not deferred, and live playlists are reloaded at regular intervals.
Are there any points in the code the reviewer needs to double check?
Aligned with #7476
Applications are expected to escalate offline errors or stalls or timeouts while offline to fatal.
Resolves issues:
Resolves #7898
Checklist